Closed
Conversation
Contributor
|
PR not needed was a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 21 Jul 23 19:51 UTC
This pull request includes multiple file diffs. Here is a summary of the changes:
The file "bus_module.go" has a new method "GetClientManager()" added to the interface "Bus".
The file "proofs.proto" contains the definition of message types and enums related to proof specifications and operations. These types are used to verify the integrity and validity of data.
The file "proofs.go" in the "ibc/types" package converts types from the IBC protocol to types used in the ICS23 library for cryptographic proofs.
The file "ibc_client_module.go" in the "shared/modules" directory manages IBC clients by defining an interface and related types and functions.
The file contains the definition of the "IBCModule" and "IBCHandler" interfaces, used in the Inter-Blockchain Communication protocol.
There is a file diff that introduces new error codes, updates existing error codes, and adds a new error function.
A new file "ibc_events.go" is added to the "shared/core/types" package, which includes a function for creating attributes.
The file "ibc_events.proto" has changes, specifically in the "Attribute" and "IBCEvent" message definitions.
Changes to the "IBCHostSubmodule" interface in the "ibc_host_module.go" file, including the removal of the "IBCHandler" interface.
Changes to the build process, including the addition of OS-specific commands, new targets, and modifications to existing targets.
Modifications to the "PersistenceReadContext" interface related to adding a new function and changing the type of a parameter.
Changes to the import paths and type names in the "ibc_event_module.go" file.
The addition of a new file "wasm.proto" that defines protocol buffer messages for a Wasm light client.
The addition of a new file "pocket.proto" that defines protocol buffer messages for the Pocket client in the IBC(Client) module.
Please review these changes and ensure they meet the desired outcomes. Let me know if you need more details or specific clarifications on any of the file diffs.
Issue
Fixes #<issue_number>
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test; if any code changes were mademake test_e2eon k8s LocalNet; if any code changes were madee2e-devnet-testpasses tests on DevNet; if any code was changedRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)